Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group - Fix overzealous regex when restoring inner containers #36221

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Group - Fix overzealous regex when restoring inner containers #36221

merged 1 commit into from
Nov 11, 2021

Conversation

davecpage
Copy link
Contributor

Description

This duplicates the fix from https://core.trac.wordpress.org/ticket/54013 onto Gutenberg.

Fixes #34199

How has this been tested?

Activated the Gutenberg plugin to see the HTML output hadn't reverted

Types of changes

Added the regex U to make quantifiers lazy

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @davecpage! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
@talldan talldan added [Block] Group Affects the Group Block [Type] Bug An existing feature does not function as intended labels Nov 5, 2021
@talldan talldan added this to 👀 Needs review in WordPress 5.9 Must-Haves via automation Nov 5, 2021
@noisysocks noisysocks added the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 7, 2021
@Mamaduka Mamaduka removed the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 10, 2021
@Mamaduka
Copy link
Member

Thanks again for fixing the regex issues, @davecpage!

I just merged #36256, so this branch will require rebasing.
@davecpage
Copy link
Contributor Author

Hi @Mamaduka i've updated the PR so it's all clean now.
Mamaduka
Mamaduka approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @davecpage.
@Mamaduka Mamaduka merged commit 22cb8f6 into WordPress:trunk Nov 11, 2021
WordPress 5.9 Must-Haves automation moved this from 👀 Needs review to ✅ Done Nov 11, 2021
@github-actions github-actions bot added this to the Gutenberg 12.0 milestone Nov 11, 2021
@noisysocks noisysocks removed the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 15, 2021
noisysocks pushed a commit that referenced this pull request Nov 15, 2021
@davecpage @noisysocks
Group - Fix overzealous regex when restoring inner containers (#36221)
1778240
@noisysocks noisysocks mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Type] Bug An existing feature does not function as intended
4 participants
@davecpage @Mamaduka @noisysocks @talldan