[RNMobile] Add crash logging options initial prop #32768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +25.9 kB (+2%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
This was referenced Jun 17, 2021
2 tasks
fluiddot
commented
Jun 23, 2021
Comment on lines
239
to
241
| let sentryModule = RNSentry() | ||
| sentryModule.gutenbergBridge = bridgeModule | ||
| sentryModule.dataSource = dataSource |
There was a problem hiding this comment.
The Sentry native module is explicitly instantiated here because it requires access to the bridge and data source.
fluiddot
commented
Jun 24, 2021
| @@ -233,6 +233,9 @@ public protocol GutenbergBridgeDelegate: class { | |||
| func gutenbergDidRequestMediaFilesUploadCancelDialog(_ mediaFiles: [[String: Any]]) | |||
|
|
|||
| func gutenbergDidRequestMediaFilesSaveCancelDialog(_ mediaFiles: [[String: Any]]) | |||
|
|
|||
| // Crash logging - Sentry | |||
| func gutenbergDidLogSentryEnvelope(_ envelope: [String: Any]) | |||
There was a problem hiding this comment.
The React Native SDK sends the events as envelopes, it's basically an object that contains all the data required to ingest an event into Sentry. This function will be used by the Sentry native module to send the events to the main apps (code reference).
|
Looks like the app is trying to send events even when they're disabled, so I'll review that part and push a fix. Here is a log extracted from the iOS console: Thanks @antonis for spotting it 🙇 ! |
|
After discussing this integration with @mchowning, we noticed that adding Sentry-specific code to the Gutenberg repo could violate the policy against adding data-gathering code. For this purpose, I decided to explore the option of moving the Sentry native module to the main apps to reduce as much as possible the references to Sentry in this repo. I made the changes in a different branch ( |
This issue has been fixed in this commit from GB-mobile. |
mchowning
reviewed
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3629WordPress-iOSPR: wordpress-mobile/WordPress-iOS#16700Automattic-Tracks-iOSPR: Automattic/Automattic-Tracks-iOS#183Description
This PR adds the Sentry native module and includes new functions to the Gutenberg bridge that would allow JS exceptions. be logged to Sentry via the main apps.
How has this been tested?
Preparation:
gutenberg/add/sentry-react-nativefrom WordPress-iOS repo and install dependencies with the commandrake dependenciesthrow new Error( 'Exception test' );npm run bundle:ios && cp -rf bundle/ios ../WordPress-iOS/Pods/Gutenberg/bundlegutenberg/add/sentry-react-nativebranch should be17.8.0.20210716), the version can be fetched from this file and the source maps can be checked by navigating to the URLhttps://sentry.io/settings/a8c/projects/wordpress-ios/source-maps/<VERSION>/.The source maps will be automatically uploaded during the release process but in case we might need to manually upload them, we could run the command
bundle exec fastlane upload_gutenberg_sourcemaps internal:truein the WordPress-iOS project. For this purpose, you would need to generate an API token in Sentry and include it in thewpios-envfile.NOTE: For version
17.8.0.20210716I already uploaded source maps.Generate Sentry issue:
Me/App Settings/Debug/Crash Logging.localDeveloper.Sentry event example: https://sentry.io/organizations/a8c/issues/2524917124/?environment=localDeveloper&project=1438083&query=is%3Aunresolved&statsPeriod=1h
Screenshots
Native crash:
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).