[RNMobile] Enable BottomSheetTextControl Component to Automatically Expand/Shrink with Text Entry #31818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
To prevent text from being clipped, padding is added to the bottom of the text area and then to the top of the surrounding tag.
2 tasks
SiobhyB
added
CSS Styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses both #31281 and #30457
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3505TL;DR: Navigate to Alt Text in the image block's settings to access the text area where alt text can be added. The area is currently a set height, but this PR changes the area so that it automatically expands/shrinks when text is entered. It should work without glitches across various devices and portrait/landscape modes.
Description
This PR seeks to address the issue outlined in #31281, which describes the fact that the BottomSheetTextControl component doesn't automatically expand/shrink with text entry.
At the moment, the component is only used in the image block's alt text settings. If you navigate to the component (by adding an image block, tapping the cog/gear icon, and then tapping Alt Text), you'll find that around three/four lines of text are visible on the screen at a time, with any more only visible upon scroll. The text area doesn't automatically expand/shrink to make multiple lines visible.
With this PR, the text area will automatically expand or shrink when multiple lines of text are entered. It will expand to a maximum of around 11 lines.
A side effect of this PR is that it will also fix the issue outlined in #30457, where there is a slight overflow of some text visible when multiple lines are added.
How has this been tested?
The following are the general steps for testing the changes introduced in this PR:
I tested the above across the following devices:
Further testing across devices of varying sizes welcomed!
Screenshots
Types of changes
Introduces a non-breaking change that slightly changes the scrolling functionality for a text area. The changes mainly involve CSS tweaks:
Checklist:
*.native.jsfiles for terms that need renaming or removal).