Remove cruft in Button block editor styles #30950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
commented
Apr 18, 2021
| @@ -33,50 +33,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| .wp-block-button__inline-link { | |||
There was a problem hiding this comment.
No longer applicable since:
a74921d#diff-e335a5733e9910d51f3adb7c21b371b738fdc190e6b9b71b19ba2ad45703fea1L153-L155
stokesman
commented
Apr 18, 2021
| } | ||
| } | ||
|
|
||
| .wp-button-label__width { |
There was a problem hiding this comment.
Introduced here:
fb1cc0e#diff-0fd478f79554ac91f10a7020b813e45f77245ddcde593682bab998b2ce2c232cR70
But looks like it was a leftover from some pre-commit WIP since a matching element cannot be found.
stokesman
added
[Block] Buttons
|
Size Change: -564 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
I came across this PR while checking for PRs that haven't been reviewed in a long time. I think this PR is also valid for the latest trunks. Neither Furthermore, I think that the following z-index definition can also be deleted. |
stokesman
force-pushed
the
update/button-block-clean-editor-styles
branch
from
eb145c7
to
adb43d6
Compare
|
Thanks for bringing up old stuff Aki! It looks like you're right about the z-index definition too so I've added a commit to remove it. |
t-hamano
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little clean-up of unused editor styles I noticed in the Button block. I'll add some links in review comments to aid review.
How has this been tested?
Before making the changes, searched for matching elements in both the codebase and the editor using Chrome’s DOM inspector and found none. After making the changes, did a superstitious check in the editor for visible changes 👀 .
Types of changes
decruftification
Checklist:
*.native.jsfiles for terms that need renaming or removal).