Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Layout resets for patterns each time a new pattern category is selected #63393

Closed
talldan opened this issue Jul 11, 2024 · 3 comments · Fixed by #63711
Closed

DataViews: Layout resets for patterns each time a new pattern category is selected #63393

talldan opened this issue Jul 11, 2024 · 3 comments · Fixed by #63711
Assignees
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jul 11, 2024

Description

Each time a pattern category is selected, the layout resets from 'Table' to 'Grid'.

This behaves differently compared to Templates or Pages, where selecting different categories on the left retains the chosen layout.

Step-by-step reproduction instructions

  1. Open the site editor
  2. Go to the patterns screen
  3. Change the layout to Table
  4. Choose a different pattern category

Expected: The layout stays as 'Table'
Actual: The layout changes back to 'Grid'

Screenshots, screen recording, code snippet

No response

Environment info

trunk
Brave / Mac OS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Jul 11, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Jul 11, 2024

Is this related (or a duplicate) of #57669, @talldan?

See #63304 (comment)

@talldan
Copy link
Contributor Author

talldan commented Jul 11, 2024

@mrfoxtalbot Similar, but not the same. That seems more of an enhancement to make sure the layout (and other) options should persist after reloading the page.

This bug is that the patterns layout option doesn't persist even when the page isn't reloaded. Switching categories is enough to make it reset. That's in contrast to how it works for templates or pages, so seems like a bug.

@mrfoxtalbot
Copy link

Makes sense. Thank you for the additional details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
3 participants