Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theme options into the customizer #93

Closed
wants to merge 2 commits into from

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Jul 26, 2019

In order to align to TRT guidelines, we should move the Gutenberg Starter theme options out of a custom admin page and into the Customizer. This PR migrates these settings over.

Testing Instructions

  1. Install the PR version of this theme on a test site, do not change any settings yet.
  2. Ensure that the options above are all active by default:
    • You should see wide and full alignment options available in the editor.
    • You should see the custom theme color palette available in the editor.
    • You should see light mode active, not dark mode.
    • You should see default block styles applied on the frontend. (A quick way to check is to verify that the quote block appears with a left border).
    • On the front end, the body should have a wp-embed-responsive class.
  3. Check and uncheck the new and verify that they toggle the options as expected.

Screenshots

Before:

Screen Shot 2019-07-26 at 12 03 08 PM

After:

Screen Shot 2019-07-26 at 12 02 34 PM

@kjellr kjellr self-assigned this Jul 26, 2019
Copy link
Member

@pattonwebz pattonwebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kjellr
Copy link
Collaborator Author

kjellr commented Aug 2, 2022

Closing due to inactivity. 🕐

@kjellr kjellr closed this Aug 2, 2022
@kjellr kjellr deleted the update/move-theme-options-to-customizer branch August 2, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants