Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple widget area in footer. #86

Closed
wants to merge 3 commits into from
Closed

Add a simple widget area in footer. #86

wants to merge 3 commits into from

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented May 29, 2019

... to make use of Gutenberg 5.8's experimental widget feature.

Currently, if you load the widget screen while this theme is active, you can't test it out:

Screen Shot 2019-05-29 at 3 40 21 PM

This PR creates a barebones widget area on the bottom of the page, so that this feature can be tested without switching themes:

Screen Shot 2019-05-29 at 3 40 04 PM

Screen Shot 2019-05-29 at 3 39 49 PM
@kjellr kjellr requested a review from karmatosed May 29, 2019 19:45
@kjellr kjellr self-assigned this May 29, 2019
mapk
mapk approved these changes Jul 21, 2020
View reviewed changes
Copy link

@mapk mapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:
@kjellr
Copy link
Collaborator Author

kjellr commented Aug 2, 2022

Closing due to inactivity. 🕐
@kjellr kjellr closed this Aug 2, 2022
@kjellr kjellr deleted the add/widget-area-in-footer branch August 2, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
2 participants
@kjellr @mapk