Persist font settings when cloning a theme #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this could work but we would be removing the possibility of having linked fonts in a cloned theme. All the fonts will be downloaded and made local as we don't have that possibility in WordPress core yet I think it's OK and nobody will expect the opposite. I will try in action to see if it solves the problem.
matiasbenedetto
approved these changes
Jul 1, 2024
|
Thanks @matiasbenedetto!
Ah yes, we can address this later once Core supports it, like you say 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should apply the "Save Fonts" save option when cloning a theme via Create Theme -> Clone Theme. This means that any font settings and files are copied over to the new cloned theme, including updating the file asset paths.
Fixes #677.
To test:
fontFace.srcpaths are relative to the cloned theme. i.e. the paths start withfile:.and not an absolute URL.