Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page: Improve design #673

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Landing Page: Improve design #673

merged 2 commits into from
Jun 18, 2024

Conversation

t-hamano
Copy link
Contributor

This small PR is to improve the design and UX of the landing page and includes three changes, and I would appreciate your feedback on whether each change makes sense.

Before

image

After

image

1. Remove custom link/button color

Respects the WordPress core link color. This color is also applied to link text in the block editor.

image

Before After
image image

2. Remove light font weight

I don't know what the intention of this style is, but the text is a little hard to read in my environment.

Before After
image image

3. Change cursor style for summary element

Indicates that the content can be opened or closed. This style also exists in the Details block.

@vcanales
Copy link
Member

I think these changes are good.

cc. @beafialho for a designer's perspective

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look like good improvements to me, but happy to defer to @beafialho before bringing them in.

@beafialho
Copy link

beafialho commented Jun 16, 2024

Fine to adjust the font weight to Regular but the intention of the design is to use the same link color as the plugin color (#3858E9). This contributes to a more cohesive, pleasurable user experience of the plugin.

@t-hamano
Copy link
Contributor Author

Thank you everyone for your reviews!

the intention of the design is to use the same link color as the plugin color (#3858E9).

I see, I've restored the link color.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @t-hamano!

@t-hamano t-hamano merged commit 8fa60a5 into trunk Jun 18, 2024
2 checks passed
@t-hamano t-hamano deleted the improve-landing-page-design branch June 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants