Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an about section in the editor #667

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

matiasbenedetto
Copy link
Contributor

What?

Add an 'About' section in the editor following the example from the admin page that will be deprecated in the next versions.

Why?

  • To provide some help to new users of the plugin.
  • The admin page could be deprecated in the next versions.

Screencast:

Screencast.from.03-06-24.13.33.21.webm
@matiasbenedetto matiasbenedetto added the enhancement New feature or request label Jun 3, 2024
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've left some comments related to keeping the markup and styling more in line with GB.

src/editor-sidebar/about.js Outdated Show resolved Hide resolved
src/plugin-sidebar.js Outdated Show resolved Hide resolved
src/plugin-styles.scss Outdated Show resolved Hide resolved
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matiasbenedetto matiasbenedetto merged commit e862dd6 into trunk Jun 3, 2024
2 checks passed
@matiasbenedetto matiasbenedetto deleted the add/about-section branch June 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants