Make external links translatable #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a translation function to some external links, since they may be locale-specific.
However, the following links remain unchanged:
create-block-theme/src/landing-page/landing-page.js
Line 193 in eabd382
create-block-theme/src/landing-page/landing-page.js
Line 206 in eabd382
GitHub URLs are the same regardless of locale.
create-block-theme/assets/boilerplate/parts/footer.html
Line 6 in eabd382
Currently it is not possible to make strings in HTML templates translatable. See the following core ticket for more information: https://core.trac.wordpress.org/ticket/60298