Fix the jslint warning from useSelect usage #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
approved these changes
May 23, 2024
Comment on lines
+35
to
+42
| const subfolder = useSelect( ( select ) => { | ||
| const stylesheet = select( 'core' ).getCurrentTheme().stylesheet; | ||
| if ( stylesheet.lastIndexOf( '/' ) > 1 ) { | ||
| return stylesheet.substring( 0, stylesheet.lastIndexOf( '/' ) ); | ||
| } | ||
| return ''; | ||
| }, [] ); | ||
|
|
There was a problem hiding this comment.
I've never tried setting initial state based on a value provided by a function called within the same component, but it doesn't seem to be a problem... so I'm inclined to approve this, albeit hesitantly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the jslint warning (or infinate loop error when fixed) from useSelect usage.
Pulled the subfolder value (once) and set it in the initial call to
useStaterather than using that state in theuseSelectwhen fetching the current theme's subfolder.Fixes jslint warning and everything works as expected.
(To test, create a new theme using the Editor interface. It should be created in the same subfolder as the currently activated theme)