Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce specifying which eslint rule is disabled when using eslint disable comments #650

Merged
merged 2 commits into from
May 23, 2024

Conversation

vcanales
Copy link
Member

Applying and enforcing this new rule reveals a lot of, for instance, no-undef rules being broken.

Applying and enforcing this new rule reveals a lot of, for instance,
no-undef rules being broken.
@vcanales vcanales marked this pull request as ready for review May 22, 2024 15:18
@vcanales vcanales changed the title Enforce specifying which eslint rule is disabled May 22, 2024
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

🚢

@vcanales vcanales merged commit 16f26cf into trunk May 23, 2024
2 checks passed
@vcanales vcanales deleted the try/enforce-eslint-disable-reason branch May 23, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants