Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #620

Merged
merged 5 commits into from
May 9, 2024
Merged

Update package-lock.json #620

merged 5 commits into from
May 9, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented May 7, 2024

I noticed that when I run npm ci on the latest trunk, package-lock.json gets updated. I think this is because only @wordpress/env in package.json was updated in #619.

Testing Instructions

  • Check out this branch and run npm i.
  • Run git diff
  • There should be no difference.
@@ -11,7 +11,6 @@
"dependencies": {
"@codemirror/lang-json": "^6.0.1",
"@uiw/react-codemirror": "^4.21.24",
"@wordpress/env": "^9.9.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is installed as devDependencies in package.json. Therefore, it is unclear why it existed as dependencies in package-lock.json.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some differences in my package-lock.json after running npm i:

  • It looks like @playwright/test, playwright, playwright/node_modules/fsevents, and typescript have been removed, but these changes haven't been committed to the package-lock.

e.g.

image
@t-hamano
Copy link
Contributor Author

t-hamano commented May 8, 2024

Thanks for the testing.

I tried regenerating package-lock.json, but does the difference still occur? By the way, if you run npm i on trunk, does a diff occur?

@mikachan
Copy link
Member

mikachan commented May 8, 2024

I tried regenerating package-lock.json, but does the difference still occur?

Yes, although not as many differences - the difference with playwright/node_modules/fsevents is not happening anymore, but the others still are (playwright and typescript). I can push my package-lock so you can see the differences if you like?

By the way, if you run npm i on trunk, does a diff occur?

Yes, I see a lot of changes in my package-lock on trunk.

@t-hamano
Copy link
Contributor Author

t-hamano commented May 8, 2024

I can push my package-lock so you can see the differences if you like?

Yes, I would appreciate it if you could push it. Your Node version is 20, right?

@mikachan
Copy link
Member

mikachan commented May 9, 2024

I've just pushed it here: 3a65a35

Your Node version is 20, right?

Yes, I'm using v20.12.2.

@t-hamano
Copy link
Contributor Author

t-hamano commented May 9, 2024

Check out the latest commits on this branch and I tried running npm i again, but the diff still occurs 😅 My Node version is also 20.12.0. Could you tell me the npm version? My npm version is 10.5.0.

@mikachan
Copy link
Member

mikachan commented May 9, 2024

My npm version is v10.5.0 too! I'm happy to go with your package-lock version, I don't think it's a big deal, but it's confusing why they're different 😅

@t-hamano
Copy link
Contributor Author

t-hamano commented May 9, 2024

I don't understand why there is a difference since the npm version and node version are exactly the same 😅

I tried regenerating package-lock.json again. Could you running the following on this branch?

rm -rf node_modules/
npm cache clear --force
npm install

If it doesn't resolve the issue, it might be better to close this PR...

Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests fine for me.
Installed dependencies from scratch and the lock file remains unchanged.

I'm keen to bring this in.

@pbking pbking merged commit d1ed884 into trunk May 9, 2024
2 checks passed
@pbking pbking deleted the update/package-lock.json branch May 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants