Remove font management #595
Conversation
Since the Font Management page is on its way out via deprecation, we should remove the js code related to it.
vcanales
requested review from
pbking,
matiasbenedetto,
mikachan,
creativecoder and
madhusudhand
src/editor-sidebar/create-panel.js
Outdated
| : '', | ||
| } ); | ||
| }, [] ); | ||
| useSelect( |
There was a problem hiding this comment.
This is a lint autofix.
There was a problem hiding this comment.
This is the only change to create-panel but now I'm seeing an error thrown.
There was a problem hiding this comment.
I rolled it back to what's in trunk and the error is gone.
There was a problem hiding this comment.
I rolled this back so that the branch was in a working state...
This change broke the app and I'm not sure why. I also attempted to remove the array rather than add theme to it with the same problem.
I'm not sure how to proceed but my 'druthers is to leave the warning for now.
…le unit test in its place rather than dismantling the unit tests
|
There are still SOME font things that CBT does to manage the fonts on save and export. I've returned those to the codebase along with the tests. I also removed some files not used as well as a few functions from the util.js. The only unit test that was in place was for a function removed so rather than dismantling the unit test framework I just stuck a sample test in there for now. (I still don't think there's anything valuable to test in the view right now, but there might be someday.) Lastly, I returned the create-panel.js to how it was on /trunk. THe change caused the create panel to break for me when I tried to use it with the change. Comments about that above. |
Removes font management code, since this functionality has been replaced by the native Font Library in Core, and therefore been deprecated.
This decouples the removal of font management from the removal of other deprecated parts of the Plugin, which is proposed in #528 but is on hold pending feature parity with the features in the editor, and an admin page that points to the new workflow.
Testing
Make sure that the following commands run without errors:
Lint
npm run lint:php && npm run lint:jsBuild
npm run buildand/ornpm run startTest
npm run test:php && npm run test:unitAfter the above, load the Plugin into your dev environment and make sure that no errors are present in the Admin, editor, and in the browser's DevTools Console.