Enhance create block theme UI [experimental] #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about moving all of this to the Site Editor plugin screen? |
|
I think it would be really nice to not have to leave the site editor to add the fonts. |
|
Closing this as all theme export options are now moved to site editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims at improving UI of the create block theme by moving to react components.
Also keeps the UI consistent with font management.
Old:
Following is the new work in progress UI.
@beafialho @henriqueiamarino could you please share your thoughts and feedback on this.
I am not sure if it is still right to keep the generate button on the left.
Note: This is UI only change for now to gain early feedback, and complete functionality is not ported yet.
Related WIP issues:
#322
#294