Core: remove an exclusion #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the exclusion is a little too aggresive. The `Generic.WhiteSpace.LanguageConstructSpacing` _will_ throw an error when there is too much whitespace, but not when there is no whitespace and the next thing is an open parenthesis. By removing the exclusion, an error will now (correctly) be thrown when there is no whitespace between a closure `use` keyword and the open parenthesis. It also means that where there is _too much_ whitespace between the keyword and the open parenthesis, two errors will be thrown, one from the `Generic.WhiteSpace.LanguageConstructSpacing` sniff and one from the `Squiz.Functions.MultiLineFunctionDeclaration` sniff. Well, so be it. As both sniffs expect the same thing, this shouldn't lead to fixer conflicts anyhow. See #764 (comment)
mukeshpanchal27
approved these changes
Dec 12, 2023
dingo-d
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the exclusion is a little too aggresive. The
Generic.WhiteSpace.LanguageConstructSpacingwill throw an error when there is too much whitespace, but not when there is no whitespace and the next thing is an open parenthesis.By removing the exclusion, an error will now (correctly) be thrown when there is no whitespace between a closure
usekeyword and the open parenthesis.It also means that where there is too much whitespace between the keyword and the open parenthesis, two errors will be thrown, one from the
Generic.WhiteSpace.LanguageConstructSpacingsniff and one from theSquiz.Functions.MultiLineFunctionDeclarationsniff.Well, so be it. As both sniffs expect the same thing, this shouldn't lead to fixer conflicts anyhow.
See #764 (comment)