CS/QA: various minor fixes #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/various-minor-fixes
branch
from
289a2c9
to
2a6a406
Compare
schlessera
requested changes
Jul 29, 2024
... for readability.
... for higher specificity and improved compatibility with tools like PHPStan.
jrfnl
force-pushed
the
feature/various-minor-fixes
branch
from
2a6a406
to
425eda5
Compare
schlessera
approved these changes
Jul 29, 2024
* Punctuation and spelling fixes.
The `BaseTestCase` class expects a child class to declare a `$transport` property. This makes that expectation explicit.
The `WpOrg\Requests\Exception::__construct()` method expects a minimum of 2 (required) parameters. While this `default` case is basically impossible to be hit, the exception creation should still be correct.
As the `$expected_attributes` and `$expected_flags` variables are optional parameters, these will always be set. However, they may not be set to an array, which is what this condition should protect against.
jrfnl
force-pushed
the
feature/various-minor-fixes
branch
from
425eda5
to
0ada535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS: minor tweak
Response\Headers\FlattenTest: minor improvement to data provider
... for readability.
Docs: favour generic type hint syntax over array type hint syntax
... for higher specificity and improved compatibility with tools like PHPStan.
Docs: various minor tweaks
Transport/BaseTestCase: make child class expectation explicit
The
BaseTestCaseclass expects a child class to declare a$transportproperty. This makes that expectation explicit.Response/Headers/GetIteratorTest: minor fix
The
WpOrg\Requests\Exception::__construct()method expects a minimum of 2 (required) parameters.While this
defaultcase is basically impossible to be hit, the exception creation should still be correct.Cookie/ParseTest: fix an incorrect condition
As the
$expected_attributesand$expected_flagsvariables are optional parameters, these will always be set. However, they may not be set to an array, which is what this condition should protect against.