Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: upgrade to Codecov v4 #880

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 8, 2024

The CodeCov v4 update makes a token for uploading code coverage a requirement. This is problematic for forks, though they try to work around this. In practice, they are failing hard though on all counts.

However, as uploading via the v3 action runner by now is failing every single run, it seems we have no choice but to update.

I've regenerated a token and added a CODECOV_TOKEN secret to the repo.

For PRs directly on this repo, that should be sufficient and should also remove the need for the wretry.action. For PRs from forks, it will be hit and miss. We'll have to see.

Refs:

@jrfnl jrfnl added this to the 2.0.x Next milestone Jul 8, 2024
@jrfnl jrfnl requested a review from schlessera July 8, 2024 04:52
@jrfnl jrfnl mentioned this pull request Jul 8, 2024
5 tasks
The CodeCov v4 update makes a token for uploading code coverage a requirement. This is problematic for forks, though they try to work around this.
In practice, they are failing hard though on all counts.

However, as uploading via the v3 action runner by now is failing _every single run_, it seems we have no choice but to update.

I've regenerated a token and added a `CODECOV_TOKEN` secret to the repo.

For PRs directly on this repo, that should be sufficient and should also remove the need for the `wretry.action`. For PRs from forks, it will be hit and miss. We'll have to see.

Refs:
* https://github.com/codecov/codecov-action/releases
* https://github.com/codecov/codecov-action/releases/tag/v4.0.0
* https://docs.codecov.com/docs/adding-the-codecov-token#github-actions
@jrfnl jrfnl force-pushed the feature/ghactions-update-codecov-action branch from 7f8f3ba to dd2e56a Compare July 8, 2024 05:30
@schlessera schlessera merged commit 775ba40 into develop Jul 8, 2024
28 checks passed
@schlessera schlessera deleted the feature/ghactions-update-codecov-action branch July 8, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants