Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing proxy temporary files to .gitignore #874

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add testing proxy temporary files to .gitignore #874

merged 1 commit into from
Jun 3, 2024

Conversation

schlessera
Copy link
Member

The testing proxy we use for testing actual HTTPS remote requests (via Python's mtmproxy) creates temporary files under the tests/utils/proxy folder:

  • a cache folder named __pycache__
  • PID files to store references to the proxy server processes

This PR adds these to the .gitignore files so they don't get accidentally committed to GitHub.
@schlessera schlessera requested a review from jrfnl June 3, 2024 10:59
@schlessera schlessera added this to the 2.1.0 milestone Jun 3, 2024
jrfnl
jrfnl approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@jrfnl jrfnl merged commit c4a34ad into develop Jun 3, 2024
26 of 28 checks passed
@jrfnl jrfnl deleted the add/ignore-testing-proxy-temporary-files branch June 3, 2024 11:23
@jrfnl jrfnl mentioned this pull request Jun 3, 2024
Closed
5 tasks
@jrfnl jrfnl modified the milestones: 2.1.0, 2.0.x Next Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: meta Type: testing/chores/QA
2 participants
@schlessera @jrfnl