Fix for the main menu bar overflow issue #995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsanevans
added
[Type] Bug
|
There are two PRs open to address the same issue. If accepting this one, please close the other: #1018 |
|
@vagelisp thanks for the PR. There seem to be some conflicts that need to be resolved before we can review this, do you think you could take a look? |
|
@vagelisp thanks for the PR. There seem to be some conflicts that need to be resolved before we can review this, do you think you could take a look? |
|
Hello @jonathanbossenger ofc, I ll get into that in the following days. |
|
Closing as this is irrelevant at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the non-English versions of Learn, the main menu bar doesn't have enough space for the translated menu items, and that's a problem.
To fix that, I altered the breaking point for the main menu. I am unsure if that's the best way to fix that problem. We could simply change the translations of the menu items, but that doesn't sound like a good solution either.
Related to #941