Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon, font size, color for Learning Duration #2651

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Jul 9, 2024

Fixes #2627 — This updates the icon for the Learning Duration block to use the SVG from figma, instead of a dashicon. It also updates the style attributes on each instance of the block so that it matches the "Lesson Count" block, which inherits text color and uses extra-small font. This matches the figma, which is 12px default text color (charcoal-1).

Before After
Screenshot 2024-07-09 at 2 14 13 PM Screenshot 2024-07-09 at 2 04 31 PM

To test

  • Add durations to some courses. This block is also used on lessons, though none on production seem to have duration; but the style update has been done for lessons as well.
  • Everywhere the duration appears, it should be 12px font size, charcoal-1 color, and the icon should be an SVG (the SVG has a thinner circle border around it)
@ryelle ryelle added the [Component] Learn Theme Website development issues related to the Learn theme. label Jul 9, 2024
@ryelle ryelle requested review from adamwoodnz and a team July 9, 2024 18:18
@ryelle ryelle self-assigned this Jul 9, 2024
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@adamwoodnz adamwoodnz merged commit 353cfe7 into trunk Jul 10, 2024
1 check passed
@adamwoodnz adamwoodnz deleted the update/duration-icon-size branch July 10, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme.
2 participants