Add banner with survey link #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a new SCSS file for this and I think I built everything correctly from there, but let me know if not. |
adamwoodnz
reviewed
Dec 5, 2022
| @@ -0,0 +1,48 @@ | |||
| .notice { | |||
There was a problem hiding this comment.
Most of this came from _locale_notice.scss, only the survey notice style is new
adamwoodnz
reviewed
Dec 5, 2022
| @@ -60,8 +60,8 @@ function update_locale_data() { | |||
| * Register style and script assets for later enqueueing. | |||
| */ | |||
| function register_assets() { | |||
| // Locale switcher script. | |||
| wp_register_script( | |||
There was a problem hiding this comment.
This meant the script was never loaded on the frontend
|
|
|
This LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a persistent banner below the primary site navigation that includes a link to the individual learner survey. Fixes #1153