-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding language metabox to the meeting post type #1139
Conversation
Fixes linting error
I used the existing metabox files to add this new one - I hope that's the right place for it, but I'm happy to move things around if there's a better location. |
Co-authored-by: Adam Wood <adam.wood@automattic.com>
wp-content/plugins/wporg-learn/views/metabox-meeting-language.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wood <adam.wood@automattic.com>
wp-content/plugins/wporg-learn/views/metabox-meeting-language.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wood <adam.wood@automattic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, just one a11y fix needed
I have added all the changes you suggested, including the a11y fix - that was a good catch! This is ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds the language metabox to the meeting post type - this completed the work done in #1009 and is necessary for the filtering in #1008 to be possible.