Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the subresource-loading explainer into the core part and the ex… #645

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

hayatoito
Copy link
Collaborator

…tension part (#623 #641)

This is the almost mechanical refactoring, splitting the
subresource-loading explainer into the core part and the extension
part. The related issues are #624 and #641.

In a follow-up PR, we might want to refine the core part so that we
can write extension parts more easily, such as having well-defined
terminologies and hook points.

…tension part (WICG#623 WICG#641)

This is the almost mechanical *refactoring*, splitting the
subresource-loading explainer into the core part and the extension
part. The related issues are WICG#624 and WICG#641.

In a follow-up PR, we might want to refine the core part so that we
can write extension parts more easily, such as having well-defined
terminologies and hook points.
Copy link
Collaborator

@horo-t horo-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thank you.

@hayatoito
Copy link
Collaborator Author

Thanks for the reviews. I'll merge the PR in a day.

@jyasskin If you have a chance to take a look, feel free to review this!

@hayatoito hayatoito merged commit 4ec4d7d into WICG:main Apr 7, 2021
@hayatoito
Copy link
Collaborator Author

cc: @littledan @jyasskin
I've merged this PR, aiming to address #623 #641.
This is just a starting point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants