-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a relative URL of a resource in a bundle. #647
Comments
#617 can be related. We need to make primary URL optional. |
Yep, I think we do this by either
|
This CL changes WebBundleParser to support relative URLs in the index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
Hi. I created a PR to support the second idea "using the bundle's URL as the base." in @jyasskin 's comment in subresource bundle. I think we can introduce a |
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
Thanks! |
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647}
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647}
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647}
…ubresourceWebBundles feature, a=testonly Automatic update from web-platform-tests Support relative URL in Web Bundle for SubresourceWebBundles feature This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647} -- wpt-commits: 68c75f6da95e3da84c83eb4930ba5a5c2341637a wpt-pr: 30416
…ubresourceWebBundles feature, a=testonly Automatic update from web-platform-tests Support relative URL in Web Bundle for SubresourceWebBundles feature This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647} -- wpt-commits: 68c75f6da95e3da84c83eb4930ba5a5c2341637a wpt-pr: 30416
Fixed. Now we support a relative URL. |
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647}
This CL changes WebBundleParser to support relative URLs in the primary URL, manifest and index section. And uses the web bundle's URL as the base URL for SubresourceWebBundles feature. Bug: 1247939, WICG/webpackage#647 Change-Id: Ie41125c293791d9209f94e59e5c9c8af3ac9778f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150318 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#924647} NOKEYCHECK=True GitOrigin-RevId: 17698fb7dfb32500eaa631a821082128a2f3faa7
It might be worth considering to support a relative URL in the bundle format.
I've heard this feature request from several people. I've searched an existing issue, but I couldn't find one so let me file an issue.
Use cases:
Regarding subresource loading use case, we use the following syntax in the main doc:
Because we have path restriction, the resources in the bundle must start with
https://example.com/app/
, such as:It seems a bit redundant. If we support a relative URL, each subresource doesn't have to include a redundant common prefix, and can be:
We have to decide on which
base
a relative URL should be resolved. For subresource loading use cases, it's clear.For other use cases, TBD.
The other benefits are:
bundle.wbn
from https://example.com/app/ to https://example.com/other/, freely, without re-creating a bundle.The text was updated successfully, but these errors were encountered: