Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storefrontRedirect to strip trailing slashes in querying for redirects #2110

Merged
merged 1 commit into from
May 15, 2024

Conversation

blittle
Copy link
Contributor

@blittle blittle commented May 14, 2024

WHY are these changes introduced?

The admin doesn't allow you to save a redirect with a trailing slash, so it should be safe to always strip it

Fixes #2090

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • [] I've added or updated the documentation
…directs

The admin doesn't allow you to save a redirect with a trailing slash, so it should be safe to always strip it
Copy link
Contributor

shopify bot commented May 14, 2024

Oxygen deployed a preview of your bl-fix-redirect-slashes branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 5:10 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 5:10 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 5:10 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 5:10 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 5:11 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 14, 2024 5:11 PM

Learn more about Hydrogen's GitHub integration.

@blittle blittle merged commit f29c908 into main May 15, 2024
13 checks passed
@blittle blittle deleted the bl-fix-redirect-slashes branch May 15, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants