Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen schema resolution #2086

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented May 7, 2024

Resolve schemas from @shopify/hydrogen instead of @shopify/hydrogen-react to avoid dependency errors.

This was originally like this to avoid problems in monorepo tests where Hydrogen wouldn't have copied schemas from Hydrogen React but it is not relevant anymore.

@frandiox frandiox requested a review from a team May 7, 2024 02:17
Copy link
Contributor

shopify bot commented May 7, 2024

Oxygen deployed a preview of your fd-fix-codegen-schema-resolution branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 2:17 AM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 2:17 AM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 2:17 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 2:17 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 2:17 AM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 7, 2024 2:19 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox merged commit ddc7196 into main May 7, 2024
13 checks passed
@frandiox frandiox deleted the fd-fix-codegen-schema-resolution branch May 7, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants