Update Miniflare to fix compatibility with Node 21 #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
frandiox
force-pushed
the
fd-update-miniflare-encoding
branch
from
b0cc797
to
b4800a9
Compare
…ix encoding issue" This reverts commit f80897a.
blittle
approved these changes
Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1833 again, since this fix was reverted in an internal refactor when stabilizing Vite.
Aside from that, Miniflare now respects
accept-encodingwhich means our responses during development can be compressed. This causes issues with our previous implementation so I'm changing the code here to use Node's HTTP instead of fetch.More info: cloudflare/workers-sdk#5409 (comment)
Update: our tests for sourcemaps started failing with the latest Miniflare version so I've downgraded it to
3.20240304.2, which still fixes the issue with Node 21 but doesn't support encoded responses.