Improve codegen warnings when missing deps #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
frandiox
commented
Apr 11, 2024
Comment on lines
-79
to
+88
| if (/\.body\[\d\]/) return; | ||
| if (/\.body\[\d\]/.test(message)) return; | ||
| if (/console\.time(End)?\(\)/.test(message)) return; |
There was a problem hiding this comment.
This was a bug, the RE wasn't tested so it was always truthy
There was a problem hiding this comment.
What was the console.time added for?
There was a problem hiding this comment.
When you run with --verbose you start seeing a loooot of warnings from Codegen that include .body or console.time(). I guess Codegen dependencies are also looking for a --verbose flag or similar, not sure.
Just muting these so that the output in the terminal is useful.
There was a problem hiding this comment.
Maybe worth a comment for that?
There was a problem hiding this comment.
There's already one above this diff: // Filter these logs even on verbose mode because it floods the terminal:
blittle
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When codegen deps are missing, this was shown before:
After these changes, we now show warnings: