-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return GraphQLError instead of objects #1765
Conversation
@@ -43,7 +43,6 @@ import { | |||
minifyQuery, | |||
assertQuery, | |||
assertMutation, | |||
extractQueryName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not use
63f048f
to
f67a7da
Compare
359b1b0
to
9ec7b38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Curious, why would you consider this a breaking change? The fact we are logging errors shouldn't break anything, no? Just more useful "noise" in the terminal.
We are changing the returned stuff to be a class instance instead of an object but I think that would only break if you do weird stuff with it 🤔
Co-authored-by: Fran Dios <frankdiox@gmail.com>
Co-authored-by: Fran Dios <frankdiox@gmail.com>
Co-authored-by: Fran Dios <frankdiox@gmail.com>
Co-authored-by: Fran Dios <frankdiox@gmail.com>
hi @frandiox I made it a breaking change because we are manipulating the message being return in the error. However, upon reflection, since it is sorta a grey area on if the string manipulation would constitute a breaking change. But our next release is not till April. I do think merging this and see if any weird breakage occur is the pragmatic call for now. |
WHY are these changes introduced?
Apply better error logging from storefront API to Customer Account API