Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shopify theme dev issue to avoid previewing the live theme instead of the development one #3706

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

karreiro
Copy link
Contributor

WHY are these changes introduced?

Fixes #3663

WHAT is this pull request doing?

This PR changes the method that cleans SFR cache to disregard the password page.

How to test your changes?

  • Run shopify theme dev in a development store
  • Open the development server in a incognito tab
  • Type the password
  • Notice the development theme appears instead of the live one

Before

After

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.
Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 72.35% 6944/9598
🟡 Branches 69.45% 3414/4916
🟡 Functions 71.32% 1855/2601
🟡 Lines 73.54% 6544/8898

Test suite run success

1654 tests passing in 765 suites.

Report generated by 🧪jest coverage report action from 1934d42

@jamesmengo
Copy link
Contributor

🎩 lgtm!

@karreiro karreiro added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 0009000 Apr 12, 2024
@karreiro karreiro deleted the theme-dev-fix branch April 12, 2024 16:54
@Arecsu
Copy link

Arecsu commented Apr 12, 2024

thank you for this fix!

@sameerxanand
Copy link

When will this fix be deployed to homebrew?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants