Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce support to Theme Access app in the new shopify theme push implementation #3675

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Apr 9, 2024

WHY are these changes introduced?

We've introduced support for the CLI in the Theme Access app supports the CLI, so we may rollback this change.

WHAT is this pull request doing?

This PR updates the push command to no longer rely in the legacy implementation when the --password flag is passed

How to test your changes?

Post-release steps

None.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.
@karreiro karreiro requested a review from jamesmengo April 9, 2024 07:27

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.14% (+0.01% 🔼)
6829/9466
🟡 Branches
69.2% (+0.02% 🔼)
3341/4828
🟡 Functions 70.96% 1823/2569
🟡 Lines
73.29% (+0.01% 🔼)
6439/8786

Test suite run success

1626 tests passing in 755 suites.

Report generated by 🧪jest coverage report action from e32854a

Copy link
Contributor

@jamesmengo jamesmengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🚢 Huge for the program!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants