Do not show api-key flag deprecation warning when using SHOPIFY_API_KEY

[gonzaloriestra]

WHY are these changes introduced?

When the SHOPIFY_API_KEY environment variable is provided, the deploy command shows this wrong warning:

WHAT is this pull request doing?

Fixes it to only show the warning when the api-key flag is provided.

How to test your changes?

• SHOPIFY_API_KEY=wadus p shopify app deploy
• p shopify app deploy --api-key wadus
• p shopify app deploy --client-id wadus

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes
• I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

[github-actions]

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

• Themes: @shopify/advanced-edits
• UI extensions: @shopify/ui-extensions-cli
  • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
• Hydrogen: @shopify/hydrogen
• Other: @shopify/cli-foundations

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	72.15% (-0% 🔻)	6828/9463
🟡	Branches	69.21% (+0.01% 🔼)	3340/4826
🟡	Functions	70.99%	1823/2568
🟡	Lines	73.3% (-0% 🔻)	6438/8783

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / ConcurrentOutput.tsx	97.62% (-2.38% 🔻)	75% (-8.33% 🔻)	100%	97.44% (-2.56% 🔻)

Test suite run success

1626 tests passing in 755 suites.

Report generated by 🧪jest coverage report action from c48e20f