Updated the Norwegian translation #313
Conversation
|
You have little faults(plural strings twice, double quotes) in your language strings update. So I did an own Pull Request based on your strings ;). Please look if it is so okay for you. And maybe you can translate the still missing strings too. |
|
I took a look at your version of the pull request, and it seems mostly good. However, the dot in string 252 is indeed meant to be there, since Norwegian uses dots where English would've used "_st", "_nd" and so on. So that "Hver 3. dag" is the equivalent of "Every 3rd day" and by extension "Every 3 days". But now that I know that my pull request is being considered for inclusion, I'll make sure to see later tonight which strings there are that I've missed out on and how many of them I am able to translate overnight. 🙂 |
|
That sounds good. Then I wait for your updated Pull Request and drop mine ;). Besides with the Translation Editor in Android Studio you can easily see which strings are missing. |
|
I've attempted to improve the translation now. If there's any strings that are still missing, then I'll have to be told about which ones I missed. PS: I couldn't find any strings about snooze delays, neither in the existing translation or in the English source strings.xml file, which means that there are two entries in Etar's settings ("Default snooze delay time" and "Ask for reminder snooze delay") that I am currently unable to translate. |
|
Nevermind, I found them. Apparently they were hiding around in cmstrings.xml. |
res/values-nb/strings.xml
Outdated
| <!-- Plural form [CHAR LIMIT=30] --> | ||
| <item quantity="other">Hver <xliff:g id="count">%d</xliff:g>. dag</item> | ||
| </plurals> | ||
| <plurals name="Ndays"> |
There was a problem hiding this comment.
Twice, please remove this and do your changes in line 44...
| @@ -274,4 +284,17 @@ | |||
| <item quantity="other" msgid="8779598489398048259">"For <xliff:g id="EVENT_COUNT">%d</xliff:g> aktiviteter"</item> | |||
| </plurals> | |||
| <string name="acessibility_recurrence_choose_end_date_description" msgid="5899029840837836711">"endre sluttdato"</string> | |||
res/values-nb/strings.xml
Outdated
| @@ -284,10 +284,11 @@ | |||
| <item quantity="other" msgid="8779598489398048259">"For <xliff:g id="EVENT_COUNT">%d</xliff:g> aktiviteter"</item> | |||
| </plurals> | |||
| <string name="acessibility_recurrence_choose_end_date_description" msgid="5899029840837836711">"endre sluttdato"</string> | |||
| <plurals name="recurrence_interval_daily"> | |||
There was a problem hiding this comment.
This plural tag already exists in line 261. There you can make your changes ;)
|
Ah, thanks for the headsup. My knowledge of coding is so-so, and as such I can't easily spot coding errors, so thanks for walking me through this. 😊 |
| @@ -259,8 +259,9 @@ | |||
| <string name="recurrence_dialog_title" msgid="8093909645557717483">"Gjenta"</string> | |||
| <string name="recurrence_dialog_title_never" msgid="2679396029776590130">"Gjentas aldri"</string> | |||
| <plurals name="recurrence_interval_daily"> | |||
| <item quantity="one" msgid="1205422710088692631">"Hver <xliff:g id="COUNT">%d</xliff:g>. dag"</item> | |||
There was a problem hiding this comment.
Please don't change the syntax(msgid)
res/values-nb/strings.xml
Outdated
| <item quantity="one" msgid="1205422710088692631">"Hver <xliff:g id="COUNT">%d</xliff:g>. dag"</item> | ||
| <item quantity="other" msgid="707566499994398250">"Hver <xliff:g id="COUNT">%d</xliff:g>. dag"</item> | ||
| <item quantity="one">"Hver dag"</item> | ||
| <!-- Plural form [CHAR LIMIT=30] --> |
|
Maybe you forgot your changes at line 44 (plurals Ndays...) |
I realised that stuff like "Hver 1 uke" is completely wrong in Norwegian, so I just as well removed the numbers from the recurrence strings.
|
Indeed I've forgot what I've changed in the Ndays plural, and therefore I also can't remember how that string is relevant to any of the other strings I've edited... 😅 |
|
No, wait, now I realise what you were hinting to. If I remember correctly, I figured out that the edits I did to Ndays in line 291 before I removed those duplicate strings, were not necessary to do after all. 🙂 |
I added some extra strings from the English values to the Norwegian strings.xml to better serve Etar's app settings, and created a store description translation.