Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YouTube-specific message to the error report page #2990

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

lenacohen
Copy link
Contributor

@lenacohen lenacohen commented Jul 2, 2024

Following up on #2974, and in response to continuing error reports for non-Privacy related issues on YouTube, I copied the YouTube-specific message on the popup onto the error reporting form. I also edited to the message to explicit reference ads, since many of the continued error reports have to do with ads playing on YouTube.

Once the new text is approved, I'll re-run make tx to update the locale files

Copy link
Member

@ghostwords ghostwords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! After making the changes, could you rewrite the commit history in the PR? (There are probably two separate sets of changes ("show YT message in error form" and "improve error form wording"), so then we will want two commits after the rebase.)

src/_locales/en_US/messages.json Outdated Show resolved Hide resolved
src/js/popup.js Show resolved Hide resolved
@lenacohen lenacohen requested a review from ghostwords July 8, 2024 21:31
@ghostwords ghostwords merged commit 2c0cf96 into master Jul 10, 2024
2 checks passed
@ghostwords ghostwords deleted the persist-youtube-message branch July 10, 2024 18:24
ghostwords added a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants