Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release process for Firefox #2988

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix release process for Firefox #2988

merged 2 commits into from
Jul 17, 2024

Conversation

ghostwords
Copy link
Member

@ghostwords ghostwords commented Jun 26, 2024 •
edited
Loading

Firefox no longer insta-approves self-hosted Privacy Badger builds. This breaks our release process.

From the most recent release:

Waiting for approval and download of signed XPI skipped. When approved the signed XPI file can be downloaded from https://addons.mozilla.org/en-US/developers/addon/privacy-badger/versions/xxxxxxx
mv: cannot stat '../pkg/privacy_badger-2024.6.14.xpi': No such file or directory
Failed to build target 2024.6.14 XPI
Failed to build target 2024.6.14 for Firefox

This PR takes all Firefox-specific steps that depend on the self-hosted XPI, and moves them to a separate script, post-firefox-release.sh.
@ghostwords ghostwords marked this pull request as ready for review July 17, 2024 16:14
@ghostwords ghostwords merged commit 3f38580 into master Jul 17, 2024
2 checks passed
@ghostwords ghostwords deleted the fix-firefox-release branch July 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation & specs task
1 participant
@ghostwords