Unset "failed to initialize" error upon successful initialization #2971
Conversation
| if (self.criticalError == "Privacy Badger failed to initialize") { | ||
| delete self.criticalError; | ||
| chrome.tabs.query({ active: true, lastFocusedWindow: true }, (tabs) => { | ||
| if (tabs[0]) { | ||
| self.updateBadge(tabs[0].id); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Why are we setting self.criticalError to "Privacy Badger failed to initialize" in dispatcher if we always delete it? Should we check for another condition before deleting? Mainly asking to make sure I understand what's going on
There was a problem hiding this comment.
We set "failed to initialize" when a content script or PB's popup or options want something, and badger.INITIALIZED is still false ten seconds after PB's background process started running.
If PB does in fact finish initializing, PB didn't fail to initialize, it was just really slow. We should unset "failed to initialize" at this point, right? Not sure what other condition we should check before deleting the error.
We could take out all of the "failed to initialize" logic, but then we would back at not knowing if PB were to ever fail to initialize again. I think not knowing is quite bad because then we're silently failing some proportion of our users.
There was a problem hiding this comment.
That makes sense, so do we not have to check any condition to confirm that PB actually initialized because this code won't run unless PB finished initializing?
There was a problem hiding this comment.
Yeah, if we got this far, badger.INITIALIZED is true.
Unset "failed to initialize" error upon successful initialization.
Following up on #2967. Fixes another part of #2966. This PR is this bit: