-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable local learning by default #2679
Conversation
Err on the side of caution.
Do not count hasn't-decided-yet-to-block domains.
When local learning is disabled
2235de1
to
f82f5ec
Compare
f82f5ec
to
6f4ecc5
Compare
8fe7a45
to
ce70180
Compare
ce70180
to
0ed8d08
Compare
Both elements (selected by class name) whose contents get localized and elements (selected by attribute) whose attributes get localized.
- "Blocked" instead of "detected" - Removed special case for one tracker - Shorter text (no "Privacy Badger", no "on this page")
Now part of a different status message, one that appears when there are no third-party domains on the page.
4a4856a
to
5002c20
Compare
To ensure widget replacement happens for all users by default.
5810e07
to
cd42fa1
Compare
cd42fa1
to
965d98d
Compare
To declutter by default (when learning is disabled).
965d98d
to
45b5a02
Compare
@Gowee Have you seen our explanation for this PR? Let me know if you have any questions. |
@ghostwords Thanks for the notifying. |
Agreed! Badger Sett's coverage is indeed limited in a number of ways. In an ideal world, we would have rolled out community learning (#1299) before turning off local learning by default. We do not believe Badger Sett alone is enough. |
Fixes #2548.
To be followed by auto-replacing the tracker database on extension update when learning is disabled. Longer term, to be followed by #1299.
The new/rearranged settings on the options page:
The new summary text in the popup:
The prompt to learn more:
The rewritten section in the new user welcome page: