Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Badger blocks website while performing Mailchimp signup #2521

Open
robali opened this issue Dec 10, 2019 · 19 comments
Open

Privacy Badger blocks website while performing Mailchimp signup #2521

robali opened this issue Dec 10, 2019 · 19 comments

Comments

@robali
Copy link

robali commented Dec 10, 2019

Privacy Badger breaks my website structurefy.com after clicking the activation-link of the Mailchimp-Signup. My CSS & JS-files get blocked.

When I click the activate-Link, I get the following message for dozens of my files:

Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

As soon as I disable Privacy Badger, everything works fine.

How to fix it?

@ghostwords
Copy link
Member

Hello and thanks for the report.

Could you explain a bit more how to reproduce this? Where can I click this activation link?

When the breakage happens, what does Privacy Badger report as blocked?

@robali
Copy link
Author

robali commented Dec 10, 2019

Thanks for the quick reply.

The problem seems to happen only in combination with Google Chrome and the Mail Client of Mac. To get the issue, you need to subscribe to my newsletter and click on the activation in the mail. Alternatively, try to click this link (as long as if doesn't expire):
https://us17.mailchimp.com/mctx/clicks?url=https%3A%2F%2Fstructurefy.us17.list-manage.com%2Fsubscribe%2Fconfirm%3Fu%3Dfad25ccedbae48ade137ffbe4%26id%3Dadcab80bc9%26e%3D39132112f7&h=b0810d0facbc4aeb5f7b79579567b0829352b0f7e03e83427b19d49a6e411028&v=1&xid=cbf16bbf7c&uid=84667521&pool=&subject=

Privacy badger says reports "structurefy.com" as blocked.

@ghostwords
Copy link
Member

OK, thank you. That link does a couple of 302 redirects that end with structurefy.com. This might be the same issue as #1997.

@robali
Copy link
Author

robali commented Dec 11, 2019

Thanks for the info.

How do I remove the 302 redirects?

So there's nothing I can do to fix the problem? Do I have to wait for the Google Chrome fix?

@ghostwords
Copy link
Member

ghostwords commented Dec 11, 2019

We're going to resolve #1997 eventually, likely sooner than later. (Chrome won't help here.)

Most users will probably never run into this because Privacy Badger needs to see tracking by a domain happen on three separate sites before blocking the domain. When you click the Mailchimp link, Privacy Badger thinks structurefy.com is tracking you on some Mailchimp domain. This is a Privacy Badger bug. However, unless your Badger sees tracking by structurefy.com on two other site domains, it won't learn to block structurefy.com.

If you want, you can see which sites your Badger thinks it saw tracking by structurefy.com on by following the debugging instructions (steps 2 and 3) for "structurefy.com".

@robali
Copy link
Author

robali commented Dec 11, 2019

Ok, but could you please explain to me again why most users won't run into this problem?

thank you!

@ghostwords
Copy link
Member

Because they don't do any of the website admin things that you do that can end up making Privacy Badger think it saw tracking multiple times. Perhaps you tested the signup flow three times, getting a different Mailchimp domain each time. We should be able to say what happened looking at the debug output.

@ghostwords
Copy link
Member

Also, I'm no longer clear on what's going on here, as rapid-navigation-related problems to Privacy Badger mean seeing domains belonging to the previous site as trackers on the new, just-navigated-to site. Whereas here we seem to have the navigated-to site blocked ... on the navigated-to site.

Which version of Privacy Badger do you have? Do you mind attaching a screenshot of Privacy Badger's popup when the problem occurs? Could you also share the debug output for "structurefy.com"?

@robali

This comment has been minimized.

@ghostwords

This comment has been minimized.

@ghostwords

This comment has been minimized.

@robali
Copy link
Author

robali commented Dec 12, 2019

sorry, my fault ...

When I click share, I get:
Privacy Badger has found 3 possible trackers on structurefy.com:
use.fontawesome.com
fonts.gstatic.com
structurefy.com

screenshot

screenshot

@ghostwords
Copy link
Member

Thanks again, this is very helpful.

When the problem occurs, could you open the popup (that says structurify was blocked on structurify ...), right-click on it, click "Inspect", select the Console tab, run the following code and share the output?

chrome.extension.getBackgroundPage().badger.tabData[POPUP_DATA.tabId].frames[0]
@robali
Copy link
Author

robali commented Dec 12, 2019

Sure, here's the output:

screenshot

ghostwords added a commit that referenced this issue Dec 13, 2019
If we run into a misattribution bug where tabData contains the wrong tab
URL, we ought to make that clear in error reports and in the UI (if only
in the Share text for now). Third-party domains already come from
tabData, so should the tab URL.

Prompted by the following posts:
- #2521 (comment)
- #2521 (comment)
ghostwords added a commit that referenced this issue Dec 13, 2019
If we run into a misattribution bug where tabData contains the wrong tab
URL, we ought to make that clear in error reports and in the UI (if only
in the Share text for now). Third-party domains already come from
tabData, so should the tab URL.

Prompted by the following posts:
- #2521 (comment)
- #2521 (comment)
@ghostwords
Copy link
Member

Can you reproduce this problem in any other way, or only when you click the Mailchimp link from the Mail app? Can you reproduce if you click the link from a webmail client?

@robali
Copy link
Author

robali commented Dec 16, 2019

The problem still exists. The only combination where the problem occurs/occurred is Google-Chrome in combination with Mac Os Mail-Client. Even if I use Google Web-Mail, everything works fine.

@robali
Copy link
Author

robali commented Dec 17, 2019

Why did you ask - did you commit a bugfix?

@ghostwords
Copy link
Member

Just trying to figure out how to reproduce. I see that other people run into this occasionally, and it seems related to following links from email newsletters and such.

@robali
Copy link
Author

robali commented Dec 18, 2019

ok, please let me know if I can help you in any way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants