Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading a file confuses Badger into thinking the tab navigated to the file's URL #2234

Open
ghostwords opened this issue Dec 4, 2018 · 0 comments
Labels
bug heuristic Badger's core learning-what-to-block functionality

Comments

@ghostwords
Copy link
Member

This can result in site breakage. For example, downloading an attachment in FastMail (fastmail.com) from fastmailusercontent.com results in Privacy Badger considering subsequent fastmail.com resources to be tracking requests.

Initiating a file download seems to produce a main_frame-type request in chrome.webRequest listeners. This is a problem since Privacy Badger considers main_frame requests to designate navigation boundaries (which we know leads to other attribution problems: #1997).

File downloads seem to produce main_frame-type requests in both Chrome and Firefox.

Ideally we would just have direct, synchronous access to the top-level/tab URL that initiated the request for every request (crbug.com/856766) so that we could easily and properly attribute requests.

Failing that, we need a way to distinguish between genuine navigation and file download requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug heuristic Badger's core learning-what-to-block functionality
1 participant