Reduce the entropy value for empty string: 3 -> 1 closes #1399 #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you go about testing this change? |
|
@ghostwords paste this in the background page while on this branch: let details = {'requestHeaders': [
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
{'name': 'cookie', 'value': "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly"},
]};
console.log(HeuristicBlocking.hasCookieTracking(details, 'foo')); |
|
Could you find out why we assigned 3 for empty strings in the first place, and whether 1 makes sense conceptually? I would discuss this with @pde. |
|
I would also like to understand what effect this change will have on actual browsing. You can add some code that flags cookies with empty strings for review (by printing just those situations to the console, let's say) and then visit a bunch of sites (in a new profile) before and (again in a new profile) after this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1399
It seems like the empty string shouldn't have more than one bit of information.