Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax cookie tracking heuristic for empty values #1399

Open
ghostwords opened this issue May 25, 2017 · 0 comments
Open

Relax cookie tracking heuristic for empty values #1399

ghostwords opened this issue May 25, 2017 · 0 comments
Labels
bug heuristic Badger's core learning-what-to-block functionality

Comments

@ghostwords
Copy link
Member

ghostwords commented May 25, 2017 •
edited
Loading

We probably shouldn't count the following parsed cookie (for medium.com from #1397) as tracking, but we currently do:

[
    "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly",
    "sid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=medium.com; secure; httponly",
    "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=.medium.com; secure; httponly",
    "sid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=.medium.com; secure; httponly",
    "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; secure; httponly",
    "sid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; secure; httponly",
    "uid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=.medium.com; secure; httponly",
    "sid=; path=/; expires=Thu, 25 May 2017 16:29:49 GMT; domain=.medium.com; secure; httponly"
  ]
All cookies for medium.com deemed low entropy...
But total estimated entropy is 24 bits, so blocking
@ghostwords ghostwords added bug heuristic Badger's core learning-what-to-block functionality labels May 25, 2017
@ghostwords ghostwords changed the title Relax cookie tracking heuristic for empty strings May 25, 2017
@cowlicks cowlicks mentioned this issue Jun 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug heuristic Badger's core learning-what-to-block functionality
1 participant
@ghostwords