Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move *.websimages.com to yellow #1244

Closed
terrorist96 opened this issue Mar 9, 2017 · 11 comments
Closed

move *.websimages.com to yellow #1244

terrorist96 opened this issue Mar 9, 2017 · 11 comments
Labels
broken site help wanted yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage

Comments

@terrorist96
Copy link
Contributor

terrorist96 commented Mar 9, 2017

http://www.nolimitmobilewindowtinting.com/
http://www.webs.com/

*.websimages.com blocks images.

@jawz101
Copy link
Contributor

jawz101 commented Mar 13, 2017

24% of the current open issues are from one person posting every time they come across a site they want to see stuff that Privacy Badger blocks. Is there an issue affecting everyone or can this one person manage their own toggles?? I mean, either there is a legitimate heuristic issue, there are one-off cases that they can manage themselves, or something else. In the end, this is a heuristic blocker- not a blocker based on hard-coded whitelists and blacklists.

24% of all tickets coming from one person is too much to clutter up an issues system.

@terrorist96
Copy link
Contributor Author

If I find an issue, I'm gonna report it. If I find an issue, I want it fixed for everyone, not selfishly fix it for myself and leave everyone else out. If I find an issue, I'm gonna report it irrespective of how many I report versus others. If I find an issue, chances are that it will impact others too, not just me. If you don't like me reporting issues, look away.

@ghostwords
Copy link
Member

@terrorist96 I appreciate the reporting! There is much we can do to improve the heuristic; having many examples of breakage is helpful.

@jawz101 I agree that we could organize better. The solution is probably to triage problems faster. This should improve in the coming months. I am open to other suggestions!

@jawz101
Copy link
Contributor

jawz101 commented Mar 13, 2017

@terrorist96 I understand but it's a heuristic engine meaning instead of a blocklist such as how adblock plus and ublock work, PB blocks based on patterns. Let's say you have 43 submitted site issues- is there enough at this point to discern a pattern which needs to be investigated to tweak a rule? You're browsing habits are likely hitting the issues we will all experience eventually and I don't know how to collect that pattern.

@ghostwords I've wondered if there could be a way to optionally contribute to an aggregated data set which could also show what people have had to manually allow.

@terrorist96
Copy link
Contributor Author

PB blocks based on patterns

I'm aware.

is there enough at this point to discern a pattern which needs to be investigated to tweak a rule?

My solution is to add my reports to the cookie block list (which has happened many times in the past but seems like addressing reported issues has slowed down a bit recently) since they are either not actually trackers and blocking them break the page, or they are trackers but still break the page and would benefit from using script surrogates.

@jawz101
Copy link
Contributor

jawz101 commented Mar 13, 2017

I just wish there was an optional opt-in thing to aggregate those things we manually allow. There is an Android XPosed module called XPrivacy which had a paid feature that aggregated everyone's security policies. If a certain number of users blocked location access for say, Facebook, there was a confidence threshold that basically meant "Nothing will break if you block location access for Facebook." and if you fetched the community rule it would apply that policy to your XPrivacy settings for that app.

Like, if PB said "35% of users have xyz.com thing set to yellow, go ahead and set mine to yellow."

@jawz101
Copy link
Contributor

jawz101 commented Mar 13, 2017

Here's that XPrivacy app. Community Ruleset page and an example of the Facebook Android ruleset

@ghostwords
Copy link
Member

@jawz101 That's a pretty cool idea and something I've been thinking about too. Could you open a feature request?

@jawz101
Copy link
Contributor

jawz101 commented Mar 14, 2017

@ghostwords will do. I guess it's one of those wishlist things that'd at least be nice to throw out there. I don't know if I should frame it as a complete "community ruleset engine" thing or an "opt-in mechanism to contribute to a dataset to improve engine heuristics and analyze current anti-privacy techniques."

So many buzzwords lol. It could serve a few purposes so I'd like to frame the things it could be leveraged for. Regardless, I'm not a fancy programmer but I'd like to write something out that communicates the idea sufficiently so it wouldn't become a short-lived topic.

The main thing is not to become a privacy concern in itself.

@ghostwords ghostwords added the yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage label Aug 18, 2017
@terrorist96
Copy link
Contributor Author

@ghostwords since you added the yellowlist tag, if I make a PR for this and #1140, will you merge it?

@ghostwords
Copy link
Member

Yes, these two seem like good candidates for yellowlisting, but I would have to look into it a bit more before merging.

ghostwords pushed a commit that referenced this issue Sep 25, 2017
Fixes #1244 and #1140.
Also reordered some domains to alphabetical order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken site help wanted yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage
4 participants