Site Health PHP check shows inaccurate status

[swb1192]

Site Health has a PHP check that returns a string related to the status of the PHP version. It should state if the PHP version is the latest version, an older (but supported) PHP version, or an older and insecure PHP version.

However, the current result states all supported versions are the "current version" of PHP.

To reproduce:

• Set up a WordPress installation
• Configure PHP as version 7.4 (supported but insecure and not the latest version)
• Go to Tools > Site Health
• View the Passed Tests

See:

"Your site is running the current version of PHP (7.4.30)"

Expected:

"Your site is running on an outdated version of PHP 7.4, which does not receive security updates. It should be updated."

[swb1192]

screenshot running php 7.4

[swissspidy]

This happens because PHP 7.4 is still the ​recommended version, so this is expected. See ​https://github.com/WordPress/wordpress-develop/blob/9cff1de6b3adcf8767bfc60c4e71b5cce81f0e1b/src/wp-admin/includes/class-wp-site-health.php#L758-L761

[swb1192]

@swissspidy Please re-open this ticket. The issue is not about whether PHP 7.4 is supported or not. The issue is that it says 7.4 is the current version of PHP. It may be recommended, but it's not the current version of PHP.

[swissspidy]

I didn't close the ticket. It is still open, the close just says closing is suggested.

[swb1192]

Got it, thank you. I can adjust the ticket copy if the intent or issue was unclear.

Updates the Site Health PHP check message to correctly refer to the currently recommended version of PHP, not the current version of PHP

Trac ticket: https://core.trac.wordpress.org/ticket/61623

[psykro]

Looking at the code, the text needs to match any version of PHP that is equal to or greater than the recommended version.

So instead of

Your site is running the current version of PHP

It could say

Your site is running at least the minimum recommended version of PHP

This way, if the PHP version exceeds whatever the current recommended version is, the wording still makes sense.

EDIT: the Github bot was quicker than I was, the patch was meant to come after the comment.

[joemcgill]

I think clarifying the wording for this health check makes sense. What doesn't make sense is that we are showing this success message also when wp_check_php_version() returns false due to an error validating the /core/serve-happy API response. We could consider changing that behavior as part of this ticket but shouldn't be blocking.

I'm also tagging for the performance focus given that this is labeled as a performance check.

[swb1192]

@psykro Thanks for the patch. Perhaps better wording could be:

Your site is running a recommended version of PHP.

[mukesh27]

Hi there!

This ticket was discussed on today's performance bug scrub.

The next step should be update site health copy text.

Move in to 6.7 for visibility.

Additional props: @swissspidy @joemcgill

[psykro]

Replying to swb1192:

@psykro Thanks for the patch. Perhaps better wording could be:

Your site is running a recommended version of PHP.

Yup, you're probably right, I'll update the patch.

[SergeyBiryukov]

In 58832:

Site Health: Improve the wording for PHP version check.

This aims to make the message more accurate by referring to the version of PHP currently recommended by WordPress, not the current version of PHP.

Follow-up to [44986], [46267], [47254].

Props swb1192, psykro, swissspidy, joemcgill, mukesh27, aristath.
See #61623.

Thanks for the PR! Merged in r58832.

[SergeyBiryukov]

Thanks everyone! Keeping the ticket open for now to also address comment:7.