Toolbar: consider moving user menu to a higher priority (after most plugins)

[sabernhardt]

With [58215], the placement of admin bar items in the top-secondary group have a different visual order. The search form is moved to the end, but the user menu and recovery mode nodes from Core could be set a later priority so plugin links stay to the left of them.

@pbiron shared screenshots in a ​comment on the dev note. They show of a set of multiple secondary nodes in a 6.5.5 site and how they look in 6.6.

@joemcgill suggested ​increasing the priority of the user menu on Slack.

[sabernhardt]

moves user menu and recovery mode nodes from priority levels 7 and 8 to 9991 and 9992

[sabernhardt]

I chose priorities close to the Search form's 9999 but wanted a few numbers for extenders to target a spot between them.

[pbiron]

thanx @sabernhardt. The patch looks good.

Having the nodes that core adds to top-secondary group more to the right (where they used to be, but now in DOM order) is good!

[joedolson]

I'm going to go ahead and milestone this for 6.6.1. If it weren't so close to release, I'd want to get it in for 6.6, so it makes sense to me that this should be considered a bug.

[arthur791004]

Is it possible to just reverse the order when rendering? Changing the order seems to be a breaking change and affects the existing behavior as well. For example, if a plugin adds the nodes to the admin bar in sequence, the order of those nodes will be changed after WP 6.6.

• Before: | 3 | 2 | 1 | - due to the float: right
• After: | 1 | 2 | 3 |

[hellofromTonya]

6.6.1 RC will likely happen late tomorrow, July 18th (no time is set yet).

During today's scrub, @joedolson noted to look at it later tonight for commit. On my review list for backporting to 6.6 branch.

[joedolson]

@arthur791004 I wouldn't consider a change in order a breaking change; there may be some special cases where the apparent order of items makes a significant difference, but mostly not. Reversing the order when adding nodes would result in a confusing and non-intuitive use of a common and standard WordPress API, so I think it's better that extenders update their code to accommodate the new order.

[joedolson]

Commit action doesn't seem to have run.
=====

[58748]:

Toolbar: Move user and recovery menus to a higher priority.

Following [58215], admin bar items in the top-secondary group have a changed visual order. Increase the priority of the user and recovery menu items so nodes added with higher priorities will still be shown visually before the user and recovery menu items, as they were prior to 58215.
The items will appear in the reverse of the previous order, but the new order now matches their priority order, rather than being the opposite.

Props sabernhardt, joemcgill, pbiron, joedolson.
Fixes #61615.

[joedolson]

Reopening for backport to 6.6.1.

[hellofromTonya]

[58748] LGTM for backport to the 6.6 branch for 6.6.1.

Doing backport commit now.

[hellofromTonya]

In 58759:

Toolbar: Move user and recovery menus to a higher priority.

Following [58215], admin bar items in the top-secondary group have a changed visual order. Increase the priority of the user and recovery menu items so nodes added with higher priorities will still be shown visually before the user and recovery menu items, as they were prior to 58215.

The items will appear in the reverse of the previous order, but the new order now matches their priority order, rather than being the opposite.

Reviewed by hellofromTonya.
Merges [58748] to the 6.6 branch.

Props sabernhardt, joemcgill, pbiron, joedolson.
Fixes #61615.

[rabmalin]

I have this in my theme:

function theme_slug_replace_howdy( $wp_admin_bar ) {
	$my_account = $wp_admin_bar->get_node( 'my-account' );
	$wp_admin_bar->add_node(
		array(
			'id'    => 'my-account',
			'title' => str_replace( 'Howdy,', 'Hello,', $my_account->title ),
		)
	);
}

add_action( 'admin_bar_menu', 'theme_slug_replace_howdy', 25 );

After 6.6.1 release I am getting following PHP warnings.

PHP Warning:  Attempt to read property "title" on null in /Users/nilambarsharma/Sites/staging/app/public/wp-content/themes/khai/functions.php on line 45
PHP Deprecated:  str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /Users/nilambarsharma/Sites/staging/app/public/wp-content/themes/khai/functions.php on line 45

I noticed priority of this hook has been changed in the above commit. PHP notice is fixed when I keep priority 9999 for my custom hook in my theme. Just reporting here because I am not sure whether this issue should be fixed in core or in my theme.

[narenin]

Hi @rabmalin,

You are correct the same thing is already reported here.

https://core.trac.wordpress.org/ticket/61738

When these priorities changed we are getting null for the given node.

$wp_admin_bar->get_node( 'my-account' )