Make WordPress Core

Opened 4 weeks ago

Last modified 6 days ago

#61578 accepted defect (bug)

Issue with search functionality in installed themes section

Reported by: nithi22's profile nithi22 Owned by: joedolson's profile joedolson
Milestone: 6.6.2 Priority: normal
Severity: normal Version: 6.6
Component: Themes Keywords: has-patch
Focuses: accessibility, administration Cc:

Description

If we navigate to Appearance > Themes and use the search box to check if a theme is already installed, it works as expected as we are entering the search term and don't press the enter key. In this instance, it will display "No themes found. Try a different search." However, if we enter the name of a theme that is not installed and press the enter key, the page will refresh and show the list of installed themes instead of displaying "No themes found. Try a different search.".

Environment

  • WordPress: 6.6-RC2
  • PHP: 8.2.0
  • Server: Apache/2.4.54 (Unix) OpenSSL/1.0.2u PHP/8.2.0 mod_wsgi/3.5 Python/2.7.18 mod_fastcgi/mod_fastcgi-SNAP-0910052141 mod_perl/2.0.11 Perl/v5.30.1
  • Database: mysqli (Server: 5.7.39 / Client: mysqlnd 8.2.0)
  • Browser: Firefox 127.0 (macOS)
  • Theme: Twenty Twenty-Four 1.1
  • MU-Plugins: None activated
  • Plugins:
    • WordPress Beta Tester 3.5.5

Steps to Reproduce

  1. Navigate to Appearance > Themes.
  2. Enter the name of a theme that is not installed in the search box.
  3. Press the enter key.
  4. Observe that the page refreshes and shows the list of installed themes instead of displaying the "No themes found. Try a different search" message.

Expected Results

  1. When pressing the enter key after entering a search term for a theme that is not installed, it should display "No themes found. Try a different search."

Actual Results

  1. When pressing the enter key after entering a search term for a theme then the page refreshes and shows the list of installed themes instead of the "No themes found. Try a different search" message.

Change History (16)

#2 @the ank
4 weeks ago

Hi,

This bug exists in Playground. However, if we download 6.6-RC2 now, it does not show that bug anymore.

Edit- Yes I can see the bug when press Enter.

Last edited 4 weeks ago by the ank (previous) (diff)

This ticket was mentioned in PR #6976 on WordPress/wordpress-develop by @the ank.


4 weeks ago
#3

  • Keywords has-patch added

#4 @sabernhardt
4 weeks ago

  • Milestone changed from Awaiting Review to 6.6
  • Version set to trunk

This ticket was mentioned in Slack in #core-test by monikarao. View the logs.


4 weeks ago

#6 @monikarao
4 weeks ago

#61601 was marked as a duplicate.

#7 @joedolson
4 weeks ago

  • Owner set to joedolson
  • Status changed from new to accepted

#8 @joedolson
4 weeks ago

  • Milestone changed from 6.6 to 6.6.1

Wish I'd seen this sooner; it could have made 6.6. At this point, however, I think it'll have to go into 6.6.1.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


3 weeks ago

#10 @hellofromTonya
3 weeks ago

6.6.1 RC will likely happen late tomorrow, July 18th (no time is set yet). Discussed this ticket in today's scrub. As the patch isn't ready yet, will move this ticket to 6.6.2 (once that milestone is available in Trac).

#11 @hellofromTonya
3 weeks ago

  • Milestone changed from 6.6.1 to 6.6.2

@the ank commented on PR #6976:


3 weeks ago
#12

All suggested changes are applied, thank you :)

@jeherve commented on PR #6976:


12 days ago
#13

This tests well for me on 6.6.1. Thanks for working on a fix!

@the ank commented on PR #6976:


12 days ago
#14

Awesome, Thank you!

#15 @sabernhardt
6 days ago

#61788 was marked as a duplicate.

#16 @josklever
6 days ago

#61788 was closed as duplicate, although it described a different location where the bug appears (wp-admin/theme-install.php). That's for installing new themes. But it's probably the same issue.

I've applied the changes on wp-admin/js/theme.js (it's probably me, because I don't understand the paths in the PR, but I guess that's the one that needs the change), but that doesn't seem to work.

Via Playground I can't test this, because it's not possible to install new theme's so the search doesn't work there.

Can somebody please test the PR by going to Appearance - Themes - Install new theme and do a search there followed by pressing enter?

Note: See TracTickets for help on using tickets.