Get WordPress

Make WordPress Core

Opened 2 months ago

Closed 6 weeks ago

#61362 closed defect (bug) (fixed)

Twenty Seventeen: add border-style for custom Pullquote block borders

Reported by: pranitdugad's profile pranitdugad Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing commit
Focuses: css Cc:

Description

Pull quote block border is not working in both frontend and backend when adding border to block

Video: ​https://jmp.sh/7mHpFrue

Attachments (2)

61362.patch​ (1.3 KB) - added by pranitdugad 2 months ago.
After applying this patch , this issue is resolved
61362.2.patch​ (916 bytes) - added by sabernhardt 2 months ago.
edits border from 0 to 0 solid

Download all attachments as: .zip

Change History (6)

@pranitdugad
2 months ago

After applying this patch , this issue is resolved

#1 @poena
2 months ago

  • Keywords changes-requested has-patch added
  • Severity changed from minor to normal

Hi @pranitdugad Thank you for opening the issue and adding the patch.

Please remember that there are contributors with visual impairments that may not be able to see the video. There must always be a written description of the problem. This is also important because the video is hosted remotely, and it may not always be available.

It is not obvious from the description in what way the border is not working.

When a border color and border width is added to the pullquote block, but no border style is chosen, the border is not visible in the editor or front.

The reason why the borders are not showing on the video is because the border: 0 also resets the border style, and there was no border style selected in the control.

The expectation would be for the border to have a solid style by default when a color is selected.

I would like to request the following changes:
The default style for the block must stay the same. There must not be any visible borders by default.

Last edited 2 months ago by poena (previous) (diff)

@sabernhardt
2 months ago

edits border from 0 to 0 solid

#2 @sabernhardt
2 months ago

  • Focuses css added; ui removed
  • Keywords needs-testing added; changes-requested removed
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Seventeen : Pull quote block border is not working in both frontend and backend to Twenty Seventeen: add border-style for custom Pullquote block borders

The border property could have 0 solid to make that the default style when the user gives the Pullquote a border width.

#3 @karmatosed
6 weeks ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.6
  • Owner set to karmatosed
  • Status changed from new to assigned

I am going to look to see if I can test this and get it into commit as looks like a good candidate. Thank you everyone.

#4 @karmatosed
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58469:

Twenty Seventeen: Resolves default border style visibility for pullquote block.

When a border color and width was added to the pullquote block but no border style was chosen the border was not visible. The expectation is that the border has a solid style by default when a color is selected.

Props pranitdugad, poena, sabernhardt.
Fixes #61362.

Note: See TracTickets for help on using tickets.