Make WordPress Core

Opened 3 months ago

Closed 6 weeks ago

#61184 closed defect (bug) (fixed)

Quote block citation text color does not match block setting with Gutenberg 18.3.0

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.6
Component: Editor Keywords: dev-feedback
Focuses: ui, css Cc:

Description

Hello Team,

I have worked on the "Quote" block and found that its "Add Citation" text color is not changed in the editor side when we tried to change text color from block setting for "Twenty Twenty-Four" theme.

In front-end side it work as expected. So, I think that it should be same on both editor & front-end sides.

I already faced this same issue on the "Twenty Fifteen" theme and I have posted it.
Issue: #59802

Here, I have attached its video.

Issue: https://www.awesomescreenshot.com/video/27535077?key=4cac598f2c43ddafa31003b223f5c066

Thanks,

Attachments (2)

Quote-block-6.5.3.png (42.9 KB) - added by sabernhardt 3 months ago.
Accent Three text color for the entire Quote block, in the iframe post editor, with Twenty Twenty-Four and WordPress 6.5.3
Quote-block-Gutenberg-18.3.0.png (43.4 KB) - added by sabernhardt 3 months ago.
gray text color for Quote block citation with Gutenberg 18.3.0 active, whether the block has the default color or user-defined text color setting

Download all attachments as: .zip

Change History (6)

@sabernhardt
3 months ago

Accent Three text color for the entire Quote block, in the iframe post editor, with Twenty Twenty-Four and WordPress 6.5.3

@sabernhardt
3 months ago

gray text color for Quote block citation with Gutenberg 18.3.0 active, whether the block has the default color or user-defined text color setting

#1 @sabernhardt
3 months ago

  • Component changed from Bundled Theme to Editor
  • Milestone changed from Awaiting Review to 6.6
  • Summary changed from Twenty Twenty-Four: The quote block Add Citation text color issue into the theme Twenty Fifteen to Quote block citation text color does not match block setting with Gutenberg 18.3.0
  • Version changed from 6.5.3 to trunk

I'm changing the version to 'trunk' because the color still matches what I selected for the Quote block in WordPress 6.5.3 with Twenty Twenty-Four 1.1 and no plugins. I only get the unexpected text color with the Gutenberg plugin activated (versions 18.2.0 and 18.3.0, whether inside the iframe or non-framed).

This is new in editor styles:

:where(.wp-element-caption, .wp-block-audio figcaption, .wp-block-embed figcaption, .wp-block-gallery figcaption, .wp-block-image figcaption, .wp-block-table figcaption, .wp-block-video figcaption) {
  color: var(--wp--preset--color--contrast-2);
  font-family: var(--wp--preset--font-family--body);
  font-size: 0.8rem;
}

The front end continues to use the same color for the whole block with Twenty Twenty-Four.

I also changed the component because this should not require special styles in individual themes.

#2 @sabernhardt
8 weeks ago

Apparently the caption class applied to the citation as early as Gutenberg 18.1, and the issue has been reported on GitHub:
https://github.com/WordPress/gutenberg/issues/62208

#3 @luehrsen
8 weeks ago

There is also a patch ready over on GitHub.

https://github.com/WordPress/gutenberg/pull/62485

#4 @sabernhardt
6 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

[58434] apparently fixed this for Beta 3.

Note: See TracTickets for help on using tickets.