Make WordPress Core

Opened 5 months ago

Closed 3 weeks ago

#60778 closed defect (bug) (invalid)

Twenty Twenty-Three: Quote block does not have difference between "Default" and "Plain" style options

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: reporter-feedback dev-feedback close
Focuses: ui, css Cc:

Description

Hello,

I have reviewed and found that the "Quote" block style is not working as expected into the Twenty Twenty-Three theme.

Here, I have attached video:

Issue: https://share.cleanshot.com/78X9q3xkwy0kkT5HvHFL

Thanks,

Change History (8)

#1 @poena
5 months ago

  • Keywords reporter-feedback added

Hi
Kindly remember that there are contributors with visual impairments, that are not able to see the content in the video, so it is important the issue is described in text, too.

Do I understand correctly that, when you add the quote block and select the plain style, you are expecting the border on the quote block to be removed?
It would be helpful to know some more details about what the expected result is and what did not work as expected.

#2 @karmatosed
4 months ago

  • Keywords dev-feedback removed

I am not totally sure what is being expected here so we do need some steps as I can't replicate any specific issues. @viralsampat can you provide them please.

#3 @viralsampat
4 months ago

Hello @karmatosed

Thank you so much for your update.

Here, I have explained what is the expected result. I think that when we change "Quote" block style from "Default" to "Plain" then "Quote" right side border behaviour not changed, It should be change based on selection.

Here, I have checked this issue in below-mentioned environment and I have prepared its video:

  • WordPress version: WordPress 6.5.2 running,
  • Themes:
    • Twenty Twenty-Three Version: 1.4
    • Twenty Twenty-Four Version: 1.1

Browser: Google Chrome, Version 123.0.6312.124 (Official Build) (arm64)
Device: MacBook Air M1
OS: macOS 14.4.1 (23E224)
Gutenberg plugin: Version 18.1.1

Issue video: https://share.cleanshot.com/zThtNbBJfT17n8Y04nXL

Thanks,

#4 @karmatosed
3 months ago

Technically this isn't a theme issue it is the block not having a block style. So I think this might need to be considered how it gets resolved at block level. @poena I am curious what you think about a solution here, it certainly is the case that this theme along with others hasn't got a block style defined, but themes don't have to.

#5 @karmatosed
2 months ago

  • Keywords dev-feedback added

#6 @sabernhardt
2 months ago

  • Summary changed from Twenty Twenty-Three Theme: The Quote block style is not working as expected. to Twenty Twenty-Three: Quote block does not have difference between "Default" and "Plain" style options

#57850 was a similar report about Twenty Twenty-One.

#7 @karmatosed
3 weeks ago

  • Keywords close added

As the previous issue #57850 had said::

The theme does not need to have different Default and Plain options. Removing the buttons from the sidebar would be nice when there is no difference, but maybe someone has made their own style with one of these by now and wants to keep the buttons.

I would agree this also stands for this one so recommend closing also.

#8 @karmatosed
3 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I am going to close this now. We can absolutely revisit, however for now lets progress as recommended. Thank you everyone.

Note: See TracTickets for help on using tickets.